Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loadingState missing in source events on iOS and tvOS #339

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Fix loadingState missing in source events on iOS and tvOS #339

merged 2 commits into from
Nov 30, 2023

Conversation

rolandkakonyi
Copy link
Contributor

Description

loadingState is missing in events where Source is used as a payload on iOS and tvOS.

Changes

Using rawValue fixes the problem

Checklist

  • 🗒 CHANGELOG entry

@rolandkakonyi rolandkakonyi self-assigned this Nov 30, 2023
@rolandkakonyi rolandkakonyi marked this pull request as ready for review November 30, 2023 13:09
@rolandkakonyi rolandkakonyi mentioned this pull request Nov 30, 2023
Merged
1 task
123mpozzi
123mpozzi approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@123mpozzi 123mpozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine, nice catch! 🚀

@rolandkakonyi rolandkakonyi merged commit 75a40c4 into development Nov 30, 2023
9 checks passed
@rolandkakonyi rolandkakonyi deleted the fix-source-events-loadingstate-mapping branch November 30, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@123mpozzi 123mpozzi 123mpozzi approved these changes

Assignees

@rolandkakonyi rolandkakonyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rolandkakonyi @123mpozzi